Subject: weird tests in arch/mips/config.in

From: Geert Uytterhoeven <[email-masked]>
Date: Thu, 11 May 2000 13:15:43 +0200 (MET DST)

I found why I no longer get IDE and serial support on my DDB Vrc-5074 board
with the current Linux/MIPS CVS tree: someone played with the conditions in
arch/mips/config.in.

What's the purpose of e.g.

    if [ "$CONFIG_DECSTATION" != "n" -a "$CONFIG_SGI_IP22" != "n" ]; then

? This is only true if you compile a kernel that supports both DECstations and
IP22s, which is not what you want. I'd expect tests like

    if [ "$CONFIG_DECSTATION" = "y" -o "$CONFIG_SGI_IP22" = "y" ]; then

or

    if [ "$CONFIG_DECSTATION" = "n" -a "$CONFIG_SGI_IP22" = "n" ]; then

FWIW, the path below is what I needed for my DDB5074. But I think the
DECstation and IP22 guys have to sort out the above conditions first.

Index: arch/mips/config.in
===================================================================
RCS file: /cvs/linux/arch/mips/config.in,v
retrieving revision 1.50
diff -u -r1.50 config.in
--- arch/mips/config.in	2000/04/19 04:00:05	1.50
+++ arch/mips/config.in	2000/05/11 10:04:50
@@ -168,13 +168,11 @@
    source net/Config.in
 fi
 
-if [ "$CONFIG_DECSTATION" != "n" -a \
-     "$CONFIG_SGI_IP22" != "n" ]; then
-    source drivers/telephony/Config.in
-fi
+if [ "$CONFIG_SGI_IP22" = "y" -o \
+     "$CONFIG_DECSTATION" = "y" -o \
+     "$CONFIG_DDB5074" = "y" ]; then
 
-if [ "$CONFIG_SGI_IP22" != "n" -a \
-     "$CONFIG_DECSTATION" != "n" ]; then
+    source drivers/telephony/Config.in
 
     mainmenu_option next_comment
     comment 'ATA/IDE/MFM/RLL support'
@@ -200,8 +198,9 @@
 fi
 endmenu
 
-if [ "$CONFIG_DECSTATION" != "n" -a \
-     "$CONFIG_SGI_IP22" != "n" ]; then
+if [ "$CONFIG_DECSTATION" = "y" -o \
+     "$CONFIG_SGI_IP22" = "y" -o \
+     "$CONFIG_DDB5074" = "y" ]; then
     source drivers/i2o/Config.in
 fi
 
@@ -268,8 +267,9 @@
    endmenu
 fi
 
-if [ "$CONFIG_DECSTATION" != "n" -a \
-     "$CONFIG_SGI_IP22" != "n" ]; then
+if [ "$CONFIG_DECSTATION" = "y" -o \
+     "$CONFIG_SGI_IP22" = "y" -o \
+     "$CONFIG_DDB5074" = "y" ]; then
    source drivers/char/Config.in
 fi

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven ------------- Sony Software Development Center Europe (SDCE)
[email-masked] ------------------- Sint-Stevens-Woluwestraat 55
Voice +32-2-7248638 Fax +32-2-7262686 ---------------- B-1130 Brussels, Belgium