MTX-1: make au1000_eth probes all PHY addresses
diff mbox

Message ID .
State Accepted
Delegated to: Ralf Baechle
Headers show

Commit Message

Florian Fainelli Feb. 27, 2011, 6:53 p.m. UTC 
From: Florian Fainelli <>

When au1000_eth probes the MII bus for PHY address, if we do not set au1000_eth
platform data's phy_search_highest_address, the MII probing logic will exit
early and will assume a valid PHY is found at address 0. For MTX-1, the PHY is
at address 31, and without this patch, the link detection/speed/duplex would not
work correctly.

CC: 
Signed-off-by: Florian Fainelli <>
---
Stable: 2.6.34+

Comments

root March 4, 2011, 4:13 p.m. UTC | #1 
On Sun, Feb 27, 2011 at 07:53:53PM +0100, Florian Fainelli wrote:

> From: Florian Fainelli <>
> 
> When au1000_eth probes the MII bus for PHY address, if we do not set au1000_eth
> platform data's phy_search_highest_address, the MII probing logic will exit
> early and will assume a valid PHY is found at address 0. For MTX-1, the PHY is
> at address 31, and without this patch, the link detection/speed/duplex would not
> work correctly.
> 
> CC: 
> Signed-off-by: Florian Fainelli <>
> ---
> Stable: 2.6.34+

Thanks, applied to 2.6.34+.  Note that while you added a
CC  that address was not actually on the mail's cc list!

  Ralf

Patch
diff mbox 

diff --git a/arch/mips/alchemy/mtx-1/platform.c b/arch/mips/alchemy/mtx-1/platform.c
index e30e42a..956f946 100644
--- a/arch/mips/alchemy/mtx-1/platform.c
+++ b/arch/mips/alchemy/mtx-1/platform.c
@@ -28,6 +28,8 @@ 
 #include <linux/mtd/physmap.h>
 #include <mtd/mtd-abi.h>
 
+#include <asm/mach-au1x00/au1xxx_eth.h>
+
 static struct gpio_keys_button mtx1_gpio_button[] = {
 	{
 		.gpio = 207,
@@ -140,10 +142,17 @@  static struct __initdata platform_device * mtx1_devs[] = {
 	&mtx1_mtd,
 };
 
+static struct au1000_eth_platform_data mtx1_au1000_eth0_pdata = {
+	.phy_search_highest_addr	= 1,
+	.phy1_search_mac0 		= 1,
+};
+
 static int __init mtx1_register_devices(void)
 {
 	int rc;
 
+	au1xxx_override_eth_cfg(0, &mtx1_au1000_eth0_pdata);
+
 	rc = gpio_request(mtx1_gpio_button[0].gpio,
 					mtx1_gpio_button[0].desc);
 	if (rc < 0) {